Issue 3015029: Replace ViewHostMsg_GetPluginPath with ViewHostMsg_GetPluginInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3015029: Replace ViewHostMsg_GetPluginPath with ViewHostMsg_GetPluginInfo. (Closed)

Created:
10 years, 4 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, jam, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Replace ViewHostMsg_GetPluginPath with ViewHostMsg_GetPluginInfo. This enables the renderer to get more information about a plugin than just the path. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54719

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : compile fixes #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -69 lines)			Patch
M	chrome/browser/plugin_service.h	View	1	2 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/plugin_service.cc	View	1	3 chunks	+9 lines, -21 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View	1	2 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/renderer/blocked_plugin.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	3 chunks	+32 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

please review. I'm trying to land http://codereview.chromium.org/2967007/ in smaller chunks; this is one of them ...

10 years, 4 months ago (2010-08-02 16:27:59 UTC) #1

LGTM

Expand Messages | Collapse Messages