Issue 3015028: Add Simplified Chinese (Pinyin) input method DOMUI configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3015028: Add Simplified Chinese (Pinyin) input method DOMUI configuration. (Closed)

Created:
10 years, 5 months ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org, satorux1, mazda

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add Simplified Chinese (Pinyin) input method DOMUI configuration. Move utility functions into a header file (currently chewing and pinyin are the customers). TEST=manually check on the netbook by uncommenting TODO lines. BUG=chromium-os:4808 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53753

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -28 lines)			Patch
M	chrome/browser/chromeos/dom_ui/language_chewing_options_handler.cc	View	1 chunk	+1 line, -27 lines	0 comments	Download
A	chrome/browser/chromeos/dom_ui/language_options_util.h	View	1 chunk	+40 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/dom_ui/language_pinyin_options_handler.cc	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_language_pinyin_options.html	View	1 chunk	+108 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kochi

Hi Erik, This time I filled in contents of Pinyin configuration DOMUI. Could you review?

10 years, 5 months ago (2010-07-26 11:37:29 UTC) #1

kochi

10 years, 5 months ago (2010-07-27 05:50:30 UTC) #3

Thanks for your review.

Satoru-san submitted this CL at 0244413aea78f4282ce9cd159cf62a1738f35976 .

Expand Messages | Collapse Messages