Issue 3015011: Address Finnur's review comments (variable names and comments) that were...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3015011: Address Finnur's review comments (variable names and comments) that were... (Closed)

Created:
10 years, 5 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews, finnur+watch_chromium.org, jshin+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Address Finnur's review comments (variable names and comments) that were dropped inadvertently when landing from a machine other than one where the original CL was written. In addition, adjust Tamil and Malayalam UI dimensions for XP. BUG=48202 TEST=In Tamil and Malyalam Chrome on XP, content-settings dialog do not have anytruncation. TBR=finnur Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53233

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	chrome/app/resources/locale_settings.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/resources/locale_settings_ml.xtb	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/resources/locale_settings_ta.xtb	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/options/content_settings_window_view.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages