Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: media/filters/ffmpeg_video_allocator.h

Issue 3014059: media: recycle buffers/direct rendering etc. (third patch) (Closed)
Patch Set: code review Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/limits.h ('k') | media/filters/ffmpeg_video_decode_engine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_video_allocator.h
diff --git a/media/filters/ffmpeg_video_allocator.h b/media/filters/ffmpeg_video_allocator.h
index 2cb1d742a4b69581589b903a1280af3b3402bd91..b72a1f114f361239f8a8b25307744933688f4777 100644
--- a/media/filters/ffmpeg_video_allocator.h
+++ b/media/filters/ffmpeg_video_allocator.h
@@ -28,7 +28,13 @@ class FFmpegVideoAllocator {
struct RefCountedAVFrame {
RefCountedAVFrame() : usage_count_(0) {}
- ~RefCountedAVFrame() { DCHECK_EQ(usage_count_, 0); }
+
+ // TODO(jiesun): we had commented out "DCHECK_EQ(usage_count_, 0);" here.
+ // Because the way FFMPEG-MT handle release buffer in delayed fashion.
+ // Probably we could wait FFMPEG-MT release all buffers before we callback
+ // the flush completion.
+ ~RefCountedAVFrame() {}
+
void AddRef() {
base::AtomicRefCountIncN(&usage_count_, 1);
}
« no previous file with comments | « media/base/limits.h ('k') | media/filters/ffmpeg_video_decode_engine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698