Issue 3014051: Create a latest link to point at newest image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3014051: Create a latest link to point at newest image (Closed)

Created:
10 years, 4 months ago by Olof Johansson

Modified:
9 years, 7 months ago

Reviewers:
davidjames

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Create a latest link to point at newest image build_image creates it after a successful build, and get_latest_image can use it if it exists. Fall back to old behavior for now when there are directories without a link. BUG=none TEST=Try building an image, check link. Rebuild, check new link.

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	build_image	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	get_latest_image.sh	View		1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davidjames

10 years, 4 months ago (2010-08-05 03:59:26 UTC) #2

LGTM w/nit

http://codereview.chromium.org/3014051/diff/1/3
File get_latest_image.sh (right):

http://codereview.chromium.org/3014051/diff/1/3#newcode35
get_latest_image.sh:35: DEFAULT_FROM="${IMAGES_DIR}/`readlink
${IMAGES_DIR}/latest`"
Please remove tabs

Expand Messages | Collapse Messages