Issue 3014049: [Mac] Integrate divider into browser-action overflow chevron.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3014049: [Mac] Integrate divider into browser-action overflow chevron. (Closed)

Created:
10 years, 4 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Bons

CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

[Mac] Integrate divider into browser-action overflow chevron. Divider shows when the mouse is not hovering. BUG=50575 TEST=divider shows when the mouse is not hovering. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54843

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -1 line)			Patch
M	chrome/browser/cocoa/extensions/browser_actions_controller.mm	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
A	chrome/browser/cocoa/extensions/chevron_menu_button.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/extensions/chevron_menu_button.mm	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/extensions/chevron_menu_button_cell.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/extensions/chevron_menu_button_cell.mm	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/extensions/chevron_menu_button_unittest.mm	View		1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Scott Hess - ex-Googler

Don't really live all the overhead to make these two trivial classes. But not sure ...

10 years, 4 months ago (2010-08-03 21:24:22 UTC) #1

LGTM