Issue 3014045: cros_mark_as_stable: fix unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3014045: cros_mark_as_stable: fix unittests (Closed)

Created:
10 years, 4 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
petkov, davidjames, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

cros_mark_as_stable: fix unittests Code was changed to add a CR. Fix tests to accomodate. BUG=5258 TEST=Unittests pass again. Change-Id: Iacdbffb14d14f60a43883db3ee12b99a5eeb9f65

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cros_mark_as_stable_unittest.py	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

davidjames

10 years, 4 months ago (2010-07-31 00:03:32 UTC) #3

This is already submitted, but some suggestions for future improvements are
below.

http://codereview.chromium.org/3014045/diff/1/2
File cros_mark_as_stable_unittest.py (right):

http://codereview.chromium.org/3014045/diff/1/2#newcode164
cros_mark_as_stable_unittest.py:164: 'KEYWORDS=\"~x86 ~arm\"', 'src_unpack(){}']
These lines should have newlines at the end

http://codereview.chromium.org/3014045/diff/1/2#newcode171
cros_mark_as_stable_unittest.py:171: m_file.write('EAPI=2')
Same here. Although this isn't a real file, output looks a lot better if it has
newlines between the lines :)

Expand Messages | Collapse Messages