2010/07/27 W. James MacLean (wjmaclean@chromium.org)

2010/07/27 W. James MacLean (wjmaclean@chromium.org)

Turn on SK_USE_FLOATBITS for Skia to force safe float-to-int conversions. This is a temporary change until Skia supports saturating float->int conversions.

TEST= existing layout tests
BUG= WebKit 25645 
      (https://bugs.webkit.org/show_bug.cgi?id=25645)

[wjmaclean, 2010-07-27 15:00:23]

Stephen,

Should we get a second reviewer? If so, can you recommend someone?

Also, I'll need to ask if you can submit it for me once the review is complete.

Cheers,

James

[Stephen White, 2010-07-27 15:48:44]

LGTM.

[wjmaclean, 2010-07-27 16:40:26]

Can you submit this for me please (if you haven't already)? If you let me
know the build #, I'll keep an eye on it while it goes through ...

Cheers,

James

On Tue, Jul 27, 2010 at 11:48 AM, <senorblanco@chromium.org> wrote:

> LGTM.
>
>
> http://codereview.chromium.org/3014039/show
>

[Peter Kasting, 2010-07-27 17:28:00]

Drive-by note:  In the future, avoid having any boilerplate at the front of your
description, is the first part of the description is shown in both email titles
and changelogs, and thus should be as descriptive as possible.

[wjmaclean, 2010-07-27 17:42:36]

Thanks for the feedback, will do in future.

Cheers,

James

On Tue, Jul 27, 2010 at 10:28 AM, <pkasting@chromium.org> wrote:

> Drive-by note:  In the future, avoid having any boilerplate at the front of
> your
> description, is the first part of the description is shown in both email
> titles
> and changelogs, and thus should be as descriptive as possible.
>
>
> http://codereview.chromium.org/3014039/show
>