Issue 3014035: AU: Add support for persistent update engine preferences store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3014035: AU: Add support for persistent update engine preferences store. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

AU: Add support for persistent update engine preferences store. BUG=5140 TEST=emerge-x86-generic, attached unit tests

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+343 lines, -0 lines)			Patch
M	SConstruct	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
A	prefs.h	View	1 2 3	1 chunk	+46 lines, -0 lines	0 comments	Download
A	prefs.cc	View	1 2 3	1 chunk	+65 lines, -0 lines	0 comments	Download
A	prefs_interface.h	View	1 2 3	1 chunk	+40 lines, -0 lines	0 comments	Download
A	prefs_unittest.cc	View	4	1 chunk	+190 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

petkov

Please take a look. The intent is that we'll initialize a Prefs object with /var/lib/update_engine/prefs ...

10 years, 5 months ago (2010-07-26 22:38:30 UTC) #1

petkov

PTAL -- ready for an actual review. From the test report: prefs.cc 32 / 32: ...

10 years, 5 months ago (2010-07-27 20:14:24 UTC) #2

nice coverage numbers :)

LGTM