Issue 3014034: Linux: Fix some NULL versus 0 issues to appease gcc-4.5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3014034: Linux: Fix some NULL versus 0 issues to appease gcc-4.5. (Closed)

Created:
10 years, 5 months ago by Craig

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, jam, darin-cc_chromium.org

Visibility:
Public.

Linux: Fix some NULL versus 0 issues to appease gcc-4.5. Patch is 99% the same as spotrh's version (thanks spot!) except for the use of gfx::kNullPluginWindow in this version. BUG=49533 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53788

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	app/gfx/gl/gl_context_linux.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/gpu/gpu_channel.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_buffer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_device_context_2d.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_font.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_scrollbar.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Craig

Any takers to review this please? (The windows trybot failure seems unrelated to the change) ...

10 years, 5 months ago (2010-07-26 18:48:42 UTC) #1

LGTM