Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: gclient.py

Issue 3014027: Add comments to clarify the purpose of some member variables. (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index d62e77ee58a3c8a49d528407e32377c0c5a5ba02..7cd2c01d3836f66e07ac39691455e8b4e11b711d 100644
--- a/gclient.py
+++ b/gclient.py
@@ -154,7 +154,12 @@ class Dependency(GClientKeywords):
# A cache of the files affected by the current operation, necessary for
# hooks.
self.file_list = []
+ # If it is not set to True, the dependency wasn't processed for its child
+ # dependency, i.e. its DEPS wasn't read.
self.deps_parsed = False
+ # A direct reference is dependency that is referenced by a deps, deps_os or
+ # solution. A indirect one is one that was loaded with From() or that
+ # exceeded recursion limit.
self.direct_reference = False
# Sanity checks
@@ -291,6 +296,8 @@ class Dependency(GClientKeywords):
if name in [s.name for s in self.dependencies]:
raise
self.dependencies.append(Dependency(self, name, url))
+ # Note: do not sort by name, the dependencies must be specified in the
+ # logical order.
logging.info('Loaded: %s' % str(self))
def RunCommandRecursively(self, options, revision_overrides,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698