[Mac] Use |-performSelector:withDelay:| to execute commands from the Wrench menu.

chrome/browser/cocoa/wrench_menu_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/wrench_menu_controller.h"
 
 #include "app/menus/menu_model.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #import "chrome/browser/cocoa/toolbar_controller.h"
 #include "chrome/browser/wrench_menu_model.h"
 
 @interface WrenchMenuController (Private)
 - (WrenchMenuModel*)wrenchMenuModel;
 - (void)adjustPositioning;
+- (void)dispatchCommandInternal:(NSNumber*)tag;
 @end
 
 @implementation WrenchMenuController
 
 - (id)init {
   self = [super init];
   return self;
 }
 
 - (void)addItemToMenu:(NSMenu*)menu
@@ skipping 62 matching lines @@
   // NSSegmentedControls (used for the Edit item) need a little help to get the
   // command_id of the pressed item.
   if ([sender isKindOfClass:[NSSegmentedControl class]])
     tag = [[sender cell] tagForSegment:[sender selectedSegment]];
 
   // The custom views within the Wrench menu are abnormal and keep the menu open
   // after a target-action. Close the menu manually.
   // TODO(rsesek): It'd be great if the zoom buttons didn't have to close the
   // menu. See http://crbug.com/48679 for more info.
   [menu_ cancelTracking];
-  [self wrenchMenuModel]->ExecuteCommand(tag);
+  // Executing certain commands from the nested run loop of the menu can lead
+  // to wonky behavior. To avoid this, schedule the dispatch on the outermost

[Nico, 2010/07/21 15:15:56]

s/ior/ior (e.g. http://crbug.com/$BUG)/

+  // run loop.
+  [self performSelector:@selector(dispatchCommandInternal:)
+             withObject:[NSNumber numberWithInt:tag]
+             afterDelay:0.0];
+}
+
+// Used to perform the actual dispatch on the outermost runloop.
+- (void)dispatchCommandInternal:(NSNumber*)tag {
+  [self wrenchMenuModel]->ExecuteCommand([tag intValue]);
 }
 
 - (WrenchMenuModel*)wrenchMenuModel {
   return static_cast<WrenchMenuModel*>(model_);
 }
 
 // Fit the localized strings into the Cut/Copy/Paste control, then resize the
 // whole menu item accordingly.
 - (void)adjustPositioning {
   NSRect itemFrame = [editItem_ frame];
@@ skipping 14 matching lines @@
   // of the segmented control.
   itemFrame.size.width += resizeAmount;
   [editItem_ setFrame:itemFrame];
 
   // Keep the spacing between the right edges of the menu and the control.
   controlFrame.origin.x = NSWidth(itemFrame) - edge - NSWidth(controlFrame);
   [editControl_ setFrame:controlFrame];
 }
 
 @end  // @implementation WrenchMenuController