Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 3014015: Remove <iostream> where possible. (Closed)

Created:
10 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, ncarter (slow), Raghu Simha, ben+cc_chromium.org, John Grabowski, amit, Paul Godavari, jam, cbentzel+watch_chromium.org, idana, darin-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, brettw-cc_chromium.org, agl, tim (not reviewing)
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Remove <iostream> where possible. <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53083

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Re-add iostream to debug_util #

Patch Set 4 : fix chrome frame compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -44 lines) Patch
M base/crypto/rsa_private_key.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/crypto/rsa_private_key_nss.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/crypto/rsa_private_key_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/linked_ptr_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/string_piece.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/nsmenuitem_additions_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/process_info_snapshot_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/filter_false_positive_perftest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/helper_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/test_launcher/test_runner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/v8_unit_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/tools/crash_service/crash_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/disassembler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gfx/insets_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gfx/point.cc View 1 chunk +1 line, -1 line 0 comments Download
M gfx/rect.cc View 1 chunk +1 line, -1 line 0 comments Download
M gfx/size.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/x509_cert_types.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/x509_cert_types.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/flip_server/balsa_frame.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/flip_server/balsa_headers.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/tools/flip_server/balsa_headers.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/flip_server/create_listener.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/create_listener.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp/library.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp/maps.cc View 1 chunk +0 lines, -1 line 0 comments Download
sandbox/linux/seccomp/sandbox_impl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 5 months ago (2010-07-19 20:56:30 UTC) #1
DaveMoore
10 years, 5 months ago (2010-07-20 00:08:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698