Issue 3013066: allow firmware fetch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3013066: allow firmware fetch (Closed)

Created:
10 years, 4 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Tom Wai-Hong Tam, adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

allow firmware fetch

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	make_factory_package.sh	View	1 2 3	4 chunks	+15 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tom Wai-Hong Tam

10 years, 4 months ago (2010-08-09 07:08:01 UTC) #2

LGTM.

I think we use the same approach as AU to do firmware update in the shim,
calling the usr/sbin/chromeos-firmwareupdate in postinst. But keeping the
original approach as a hack is also fine.

Expand Messages | Collapse Messages