Issue 3013054: Add a WATCHLIST to the update engine repo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3013054: Add a WATCHLIST to the update engine repo. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Add a WATCHLIST to the update engine repo.

Patch Set 1 #

Patch Set 2 : Add a WATCHLIST to the update engine repo. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	A	WATCHLISTS	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 4 months ago (2010-08-02 22:21:46 UTC) #2

LGTM

On Mon, Aug 2, 2010 at 3:08 PM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> Add a WATCHLIST to the update engine repo.
>
> Please review this at http://codereview.chromium.org/3013054/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  A WATCHLISTS
>
>
> Index: WATCHLISTS
> diff --git a/WATCHLISTS b/WATCHLISTS
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..bcce0de360cf025a96560454641490f9e8325614
> --- /dev/null
> +++ b/WATCHLISTS
> @@ -0,0 +1,14 @@
> +# See http://dev.chromium.org/developers/contributing-code/watchlists for
> +# a description of this file's format.
> +# Please keep these keys in alphabetical order.
> +
> +{
> +  'WATCHLIST_DEFINITIONS': {
> +    'all': {
> +      'filepath': '.',
> +    },
> +  },
> +  'WATCHLISTS': {
> +    'all': ['adlr@chromium.org', 'petkov@chromium.org']
> +  },
> +}
>
>
>

Expand Messages | Collapse Messages