Let the Nigori client import and export raw encryption keys.

Let the Nigori client import and export raw encryption keys.

BUG=48701
TEST=NigoriTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54970

[tim (not reviewing), 2010-08-04 06:40:47]

http://codereview.chromium.org/3013047/diff/3001/4002
File chrome/browser/sync/util/nigori.cc (right):

http://codereview.chromium.org/3013047/diff/3001/4002#newcode163
chrome/browser/sync/util/nigori.cc:163: // TODO(albertb): Use a secure random
function.
nit - could you file a bug for this?

http://codereview.chromium.org/3013047/diff/3001/4003
File chrome/browser/sync/util/nigori.h (right):

http://codereview.chromium.org/3013047/diff/3001/4003#newcode31
chrome/browser/sync/util/nigori.h:31: // Creates a Nigori client for
communicating with |hostname|.
guess |hostname| isn't relevant here now

http://codereview.chromium.org/3013047/diff/3001/4003#newcode32
chrome/browser/sync/util/nigori.h:32: explicit Nigori();
remove explicit

http://codereview.chromium.org/3013047/diff/3001/4003#newcode40
chrome/browser/sync/util/nigori.h:40: // Initialize the client by importing the
given keys instead of deriving new
hm, Initialize the client? Should we call these InitByDerivation and one
InitByImport?

[albertb, 2010-08-04 18:25:57]

http://codereview.chromium.org/3013047/diff/3001/4002
File chrome/browser/sync/util/nigori.cc (right):

http://codereview.chromium.org/3013047/diff/3001/4002#newcode163
chrome/browser/sync/util/nigori.cc:163: // TODO(albertb): Use a secure random
function.
On 2010/08/04 06:40:47, timsteele wrote:
> nit - could you file a bug for this?

Filed crbug.com/51174

http://codereview.chromium.org/3013047/diff/3001/4003
File chrome/browser/sync/util/nigori.h (right):

http://codereview.chromium.org/3013047/diff/3001/4003#newcode31
chrome/browser/sync/util/nigori.h:31: // Creates a Nigori client for
communicating with |hostname|.
On 2010/08/04 06:40:47, timsteele wrote:
> guess |hostname| isn't relevant here now

Done.

http://codereview.chromium.org/3013047/diff/3001/4003#newcode32
chrome/browser/sync/util/nigori.h:32: explicit Nigori();
On 2010/08/04 06:40:47, timsteele wrote:
> remove explicit

Done.

http://codereview.chromium.org/3013047/diff/3001/4003#newcode40
chrome/browser/sync/util/nigori.h:40: // Initialize the client by importing the
given keys instead of deriving new
On 2010/08/04 06:40:47, timsteele wrote:
> hm, Initialize the client? Should we call these InitByDerivation and one
> InitByImport?

Done.

[tim (not reviewing), 2010-08-04 21:19:40]

LGTM