Issue 3013042: Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory le...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3013042: Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory le... (Closed)

Created:
10 years, 4 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
davejcool

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory leak on the build bots when PulseAudio was initialized on a separate worker thread. This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread. For some reason, the init finishes cleanly on one thread, but not the other. BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141) TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures. Review URL: http://codereview.chromium.org/3026028 TBR=davej@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54170

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/browser/chromeos/audio_handler.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	chrome/browser/chromeos/audio_handler.cc	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)