Issue 3013039: Enhance plugin logging a bit. This adds logging in a few more places, especia...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3013039: Enhance plugin logging a bit. This adds logging in a few more places, especia... (Closed)

Created:
10 years, 4 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, John Grabowski, jam, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enhance plugin logging a bit. This adds logging in a few more places, especially for Windows. This also changes the log level to ERROR so that when you opt in to plugin logging, you don't also have to set the log level to be INFO and put up with a low of log spew. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54008

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -29 lines)			Patch
M	webkit/glue/plugins/plugin_lib.cc	View	5 chunks	+11 lines, -9 lines	0 comments	Download
M	webkit/glue/plugins/plugin_lib_posix.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	webkit/glue/plugins/plugin_lib_win.cc	View	3 chunks	+9 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/plugin_list_posix.cc	View	4 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages