Issue 3013038: Fix lines longer than 80 characters.

Issue 3013038: Fix lines longer than 80 characters. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Fix lines longer than 80 characters. BUG=50266 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53958

Patch Set 1 : #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -15 lines)			Patch
M	base/ref_counted.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/child_process_security_policy.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ime_input.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/webkit_param_traits.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

LG, thanks! Curious: What's up with the "Signed-off-by: Thiago Farina <tfarina@chromium.org>" line? Seems like that's ...

10 years, 4 months ago (2010-07-28 15:56:57 UTC) #2

tfarina

On 2010/07/28 15:56:57, Nico wrote: > LG, thanks! > > Curious: What's up with the ...

10 years, 4 months ago (2010-07-28 16:20:19 UTC) #3

Nico

10 years, 4 months ago (2010-07-28 16:23:49 UTC) #4

On Wed, Jul 28, 2010 at 9:20 AM,  <tfarina@chromium.org> wrote:
> On 2010/07/28 15:56:57, Nico wrote:
>>
>> LG, thanks!
>
>> Curious: What's up with the "Signed-off-by: Thiago Farina
>> <tfarina@chromium.org>" line? Seems like that's not necessary, svn and git
>
> know
>>
>> about the author of a CL even if you don't put that in there. And no other
>> committer does that…
>
> I think it's a good pratice, many other open source projects does this, git
> and
> linux are just two examples. There is one other committer but from Chromium
> OS
> that does this, Benson Leung (bleung@chromium.org).

We don't do this in chromium, and I don't see why it's useful when
you're landing patches you wrote yourself. It's in the author field
already (see e.g. http://src.chromium.org/viewvc/chrome?view=rev ).
Sounds like bleung is doing it wrong, too :-)

>
> http://codereview.chromium.org/3013038/show
>

Expand Messages | Collapse Messages