Issue 3013035: Add html node info (tag name, attributes, and computed display) and document...

Issue 3013035: Add html node info (tag name, attributes, and computed display) and document... (Closed)

Created:
10 years, 4 months ago by dmazzoni

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Paweł Hajdan Jr., dglazkov, dglazkov1

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Chris Guillory, David Tseng, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add html node info (tag name, attributes, and computed display) and document info (url, title, mimetype, doctype) to WebAccessibility. BUG=none TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57188 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57866

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : Add html node info (tag name, attributes, and computed display) and document... #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -8 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1 2 3 4 5 6	3 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 2 3 4 5 6	3 chunks	+5 lines, -6 lines	0 comments	Download
A	chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc	View		1 chunk	+109 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/render_messages.cc	View	3 4 5 6	3 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_unittest.cc	View	1 2 3 4 5 6	2 chunks	+13 lines, -0 lines	0 comments	Download
M	webkit/glue/webaccessibility.h	View	1 2 3 4 5 6	2 chunks	+12 lines, -0 lines	0 comments	Download
M	webkit/glue/webaccessibility.cc	View	1 2 3 4 5 6	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

Darin, Dmitri, This is for either of you; it's the code that uses the new ...

10 years, 4 months ago (2010-07-28 21:44:30 UTC) #1

Paweł Hajdan Jr.

Drive-by with a minor test comment. No need to wait for another review by me. ...

10 years, 4 months ago (2010-08-13 17:27:00 UTC) #3

dmazzoni

10 years, 4 months ago (2010-08-13 17:54:20 UTC) #4

On Fri, Aug 13, 2010 at 10:27 AM, <phajdan.jr@chromium.org> wrote:

> Drive-by with a minor test comment. No need to wait for another review by
> me.
>
>
> http://codereview.chromium.org/3013035/diff/20001/21003
> File chrome/browser/renderer_host/renderer_accessibility_browsertest.cc
> (right):
>
> http://codereview.chromium.org/3013035/diff/20001/21003#newcode76
> chrome/browser/renderer_host/renderer_accessibility_browsertest.cc:76:
> ASSERT_EQ(1, static_cast<int>(tree.children.size()));
> nit: 1U and get rid of the static_cast. Please also fix other places in
> this file.


Done, thanks.



>
>
> http://codereview.chromium.org/3013035/show
>

Expand Messages | Collapse Messages