Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: gclient.py

Issue 3013031: Disable the duplicate dependency check to get pagespeed back to sync. (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index c3e696423783fb632eae6a6ba9564e302e495ff3..bf7b6ad6d998b65346d66280de455d9734b686aa 100644
--- a/gclient.py
+++ b/gclient.py
@@ -165,11 +165,13 @@ class Dependency(GClientKeywords):
# Sanity checks
if not self.name and self.parent:
raise gclient_utils.Error('Dependency without name')
- tree = dict((d.name, d) for d in self.tree(False))
- if self.name in tree:
- raise gclient_utils.Error(
- 'Dependency %s specified more than once:\n %s\nvs\n %s' %
- (self.name, tree[self.name].hierarchy(), self.hierarchy()))
+ # TODO(maruel): http://crbug.com/50015 Reenable this check once
+ # self.tree(False) is corrected.
+ # tree = dict((d.name, d) for d in self.tree(False))
+ #if self.name in tree:
+ # raise gclient_utils.Error(
+ # 'Dependency %s specified more than once:\n %s\nvs\n %s' %
+ # (self.name, tree[self.name].hierarchy(), self.hierarchy()))
if not isinstance(self.url,
(basestring, self.FromImpl, self.FileImpl, None.__class__)):
raise gclient_utils.Error('dependency url must be either a string, None, '
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698