Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 3013030: AU: when cutting a cycle, add proper dependencies. (Closed)

Created:
10 years, 5 months ago by adlr
Modified:
9 years ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/update_engine.git
Visibility:
Public.

Description

AU: when cutting a cycle, add proper dependencies. The old behavior was: Imagine a cycle: A->B->C->D->A. We cut A->B which creates the graph: B->C->D->A->New. We depended on B to depend (indirectly) on New. The problem is, say we cut two edges, A->B and C->D. Then the result would be: D->A->New and B->C->New2. Now, B no longer depdends (directly or indirectly) on New. Now, When we cut a cycle, we have both the src/dst of the cut edge depends on the New node. Following the example, this new behavior gives us: A->New<-B->C->New2<-D->A It's both cycle free and doesn't lose the fact that B depends New. BUG=chromium-os:5061 TEST=unittest, tested on generating delta that needed this fix

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M delta_diff_generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M delta_diff_generator_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
adlr
10 years, 5 months ago (2010-07-23 03:57:20 UTC) #1
petkov
10 years, 5 months ago (2010-07-23 06:39:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698