Issue 3013012: Revert 52859.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3013012: Revert 52859. (Closed)

Created:
10 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
tfarina

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

Revert 52859. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52860 TBR=tfarina

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -90 lines)			Patch
M	chrome/browser/gtk/notifications/balloon_view_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/gtk/notifications/notification_options_menu_model.h	View	1 chunk	+43 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/notifications/notification_options_menu_model.cc	View	1 chunk	+90 lines, -0 lines	0 comments	Download
D	chrome/browser/notifications/notification_options_menu_model.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/notifications/notification_options_menu_model.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pfeldman

10 years, 5 months ago (2010-07-18 18:36:14 UTC) #2

On 2010/07/18 18:21:19, tfarina wrote:
> Hey, why you reverted it?

Chromium builder failed compile + did not find you on the channel. Tree has no
sheriff, so we should be careful. Failure details below:

http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder/buil...

9>------ Build started: Project: chrome_dll_nacl_win64, Configuration: Release
x64 ------
7>.\browser\notifications\notification_options_menu_model.cc(17) : error C2220:
warning treated as error - no 'object' file generated
7>.\browser\notifications\notification_options_menu_model.cc(17) : warning
C4355: 'this' : used in base member initializer list
7>Build log was saved at
"file://C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\browser\BuildLog.htm"
7>browser - 1 error(s), 1 warning(s)

Expand Messages | Collapse Messages