Issue 3012048: Build accelerated compositor by default on Mac OS X to ensure no...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3012048: Build accelerated compositor by default on Mac OS X to ensure no... (Closed)

Created:
10 years, 4 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
vrk (LEFT CHROMIUM), Vangelis Kokkevis, dglazkov

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Build accelerated compositor by default on Mac OS X to ensure no compilation regressions in the associated code. BUG=38969 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55763

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/features_override.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Vangelis Kokkevis

Looks good, as long as the mac try build succeeds.

10 years, 4 months ago (2010-08-06 00:45:15 UTC) #2

Vangelis Kokkevis

10 years, 4 months ago (2010-08-07 01:40:39 UTC) #3

The VideoLayerChromium needs its skia specific code to be put behind a

#if PLATFORM(SKIA)

for the mac port to compile.