|
|
Revert 54560 -
Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances.
I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2941001
TBR=twiz@google.com
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54565
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+91 lines, -106 lines) |
Patch |
 |
M |
chrome/browser/autofill/autofill_cc_infobar_delegate.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/autofill_cc_infobar_delegate.cc
|
View
|
|
3 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/autofill_manager.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser.h
|
View
|
|
3 chunks |
+4 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser.cc
|
View
|
|
8 chunks |
+22 lines, -34 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser_browsertest.cc
|
View
|
|
9 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser_init.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/tab_strip_controller_unittest.mm
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/dom_ui/dom_ui.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/dom_ui/dom_ui.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/dom_ui/history2_ui.cc
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/dom_ui/history_ui.cc
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_dom_ui.cc
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/external_tab_container_win.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/tab_contents/tab_contents.cc
|
View
|
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/tab_contents/tab_contents_delegate.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/tab_contents/tab_contents_delegate.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/tabs/tab_strip_model.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/tabs/tab_strip_model_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/views/frame/browser_view.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/views/tabs/browser_tab_strip_controller.h
|
View
|
|
3 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/views/tabs/browser_tab_strip_controller.cc
|
View
|
|
3 chunks |
+9 lines, -12 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|
Chromium Code Reviews
Issue
3012042:
Revert 54560 - ... (Closed)
