Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 3012007: Revert 52787 - Make the personal stuff page viewable.... (Closed)

Created:
10 years, 5 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
sargrass
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 52787 - Make the personal stuff page viewable. BUG=48883 TEST=Exercise Personal Stuff page via --enabled-tabbed-options Review URL: http://codereview.chromium.org/2819046 TBR=sargrass@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -394 lines) Patch
A + chrome/browser/chromeos/dom_ui/sync_options_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/dom_ui/sync_options_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/dom_ui/options_ui.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/personal_options_handler.cc View 2 chunks +23 lines, -68 lines 0 comments Download
D chrome/browser/dom_ui/sync_options_handler.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/dom_ui/sync_options_handler.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/browser/resources/options.html View 2 chunks +1 line, -3 lines 0 comments Download
D chrome/browser/resources/options/personal_options.css View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/personal_options.html View 1 chunk +0 lines, -143 lines 0 comments Download
M chrome/browser/resources/options/personal_options.js View 1 chunk +2 lines, -47 lines 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
10 years, 5 months ago (2010-07-17 06:07:56 UTC) #1
Lei Zhang
10 years, 5 months ago (2010-07-17 06:10:20 UTC) #2
Linux Builder Views went red:

OptionsUITest.LoadOptionsByURL: 
[14300:14300:7086937698407:WARNING:chrome/installer/util/master_preferences.cc(167)]
Master preferences file not found:
/b/slave/chromium-dbg-linux-views/build/src/out/Debug/master_preferences
[14300:14300:7086937916813:WARNING:views/widget/widget_gtk.cc(291)] compositing
not supported; allowing anyway
LEAK: 4 WebCoreNode
[14300:14300:7086938535719:FATAL:chrome/browser/pref_service.cc(454)] Check
failed: false. Trying to add an observer for an unregistered pref:
browser.custom_chrome_frame
Backtrace:
	StackTrace::StackTrace() [0x8a6b736]
	logging::LogMessage::~LogMessage() [0x8a80c33]
	PrefService::AddPrefObserver() [0x828792b]
	CoreOptionsHandler::ObservePref() [0x881159d]
	CoreOptionsHandler::HandleObservePrefs() [0x8811c15]
	DispatchToMethod<>() [0x881351d]
	CallbackImpl<>::RunWithParams() [0x881354c]
	CallbackRunner<>::Run<>() [0x8539074]
	DOMUI::ProcessDOMUIMessage() [0x853834e]
	TabContents::ProcessDOMUIMessage() [0x8377a2d]
	RenderViewHost::OnMsgDOMUISend() [0x82bb794]
	DispatchToMethod<>() [0x82c278c]
	IPC::MessageWithTuple<>::Dispatch<>() [0x82ca581]
	RenderViewHost::OnMessageReceived() [0x82c056b]
	BrowserRenderProcessHost::OnMessageReceived() [0x865bf88]
	IPC::ChannelProxy::Context::OnDispatchMessage() [0x9306896]
	DispatchToMethod<>() [0x93076c7]
	RunnableMethod<>::Run() [0x9307703]
	MessageLoop::RunTask() [0x8a82a01]
	MessageLoop::DeferOrRunPendingTask() [0x8a82aad]
	MessageLoop::DoWork() [0x8a82d3d]
	base::MessagePumpForUI::HandleDispatch() [0x8adbf60]
	(anonymous namespace)::WorkSourceDispatch() [0x8adbfb8]
	0x4068fcf6
	0x406930b3
	0x4069366e
	base::MessagePumpForUI::RunWithDispatcher() [0x8adc547]
	MessageLoop::RunInternal() [0x8a8354a]
	MessageLoop::RunHandler() [0x8a83589]
	MessageLoopForUI::Run() [0x8a835be]
	(anonymous namespace)::RunUIMessageLoop() [0x80ab103]
	BrowserMain() [0x80ad650]
	ChromeMain [0x8049fd2]
	main [0x804b3a3]
	0x40cc1450
	0x80481a1

chrome/test/ui/ui_test.cc:607: Failure
Value of: tab_proxy->NavigateToURLBlockUntilNavigationsComplete( url,
number_of_navigations)
  Actual: 0
Expected: AUTOMATION_MSG_NAVIGATION_SUCCESS
Which is: 1
chrome://options/
chrome/browser/dom_ui/options_ui_uitest.cc:26: Failure
Value of: tab->GetTabTitle(&title)
  Actual: false
Expected: true
chrome/test/ui/ui_test.cc:187: Failure
Value of: assertions.size()
  Actual: 1
Expected: expected_errors_
Which is: 0
The following error(s) occurred in the application during this test:

[14300:14300:7086938535719:FATAL:chrome/browser/pref_service.cc(454)] Check
failed: false. Trying to add an observer for an unregistered pref:
browser.custom_chrome_frame

Powered by Google App Engine
This is Rietveld 408576698