Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: base/process_util.h

Issue 3012004: Revert 52608 - Add and alternative GetAppOutput() to process_util that takes ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/process_util_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util.h
===================================================================
--- base/process_util.h (revision 52612)
+++ base/process_util.h (working copy)
@@ -85,9 +85,6 @@
// A minimalistic but hopefully cross-platform set of exit codes.
// Do not change the enumeration values or you will break third-party
// installers.
-// Warning: This enum is duplicated and extended in chrome/common/result_codes.h
-// The two must be kept in sync and users of that enum would prefer the
-// numbering didn't change.
enum {
PROCESS_END_NORMAL_TERMINATION = 0,
PROCESS_END_KILLED_BY_USER = 1,
@@ -242,15 +239,6 @@
bool GetAppOutput(const CommandLine& cl, std::string* output);
#if defined(OS_POSIX)
-// Similar to |GetAppOutput()|. Returns true if process launched and
-// exited cleanly, with exit code indicating success. Waits no more than
-// |timeout_milliseconds| for the launched process to exit. After timeout
-// is triggered, the process is killed and true is stored in |timed_out|.
-// Will wait for process to die so this may overrun |timeout_milliseconds|.
-// TODO(tessamac): implement this for windows.
-bool GetAppOutputWithTimeout(const CommandLine& cl, std::string* output,
- bool* timed_out, int timeout_milliseconds);
-
// A restricted version of |GetAppOutput()| which (a) clears the environment,
// and (b) stores at most |max_output| bytes; also, it doesn't search the path
// for the command.
« no previous file with comments | « no previous file | base/process_util_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698