Move implementation from header to source.

base/command_line.cc

Index: base/command_line.cc
diff --git a/base/command_line.cc b/base/command_line.cc
index 2c6ef0b801c6d20ed099be9c3dc289c7f4f3ec86..a4500798878696b14414787dc123d0b2f1d52a51 100644
--- a/base/command_line.cc
+++ b/base/command_line.cc
@@ -55,6 +55,9 @@ static void Lowercase(std::string* parameter) {
 }
 #endif
 
+CommandLine::~CommandLine() {
+}
+
 #if defined(OS_WIN)
 CommandLine::CommandLine(ArgumentsOnly args_only) {
 }
@@ -437,3 +440,6 @@ void CommandLine::PrependWrapper(const std::wstring& wrapper_wide) {
 }
 
 #endif
+
+CommandLine::CommandLine() {

[Evan Martin, 2010/07/15 17:37:33]

Maybe add a comment near this saying "private".  It seems really strange
otherwise.  Perhaps put it near the other ctors?

Since this is never used, does it really cost us during builds?

[Elliot Glaysher, 2010/07/15 18:08:10]

Added comment.
 
Yes. Because the code for the constructor is still emitted. Individually, the
cost of this constructor is probably small, but the theory behind this patch is
death by a hundred papercuts.

+}