Move implementation from header to source.

base/tracked.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Tracked is the base class for all tracked objects.  During construction, it
 // registers the fact that an instance was created, and at destruction time, it
 // records that event.  The instance may be tagged with a name, which is refered
 // to as its Location.  The Location is a file and line number, most
 // typically indicated where the object was constructed.  In some cases, as the
@@ skipping 21 matching lines @@
 
 //------------------------------------------------------------------------------
 // Location provides basic info where of an object was constructed, or was
 // significantly brought to life.
 
 class Location {
  public:
   // Constructor should be called with a long-lived char*, such as __FILE__.
   // It assumes the provided value will persist as a global constant, and it
   // will not make a copy of it.
-  Location(const char* function_name, const char* file_name, int line_number)
-      : function_name_(function_name),
-        file_name_(file_name),
-        line_number_(line_number) { }
+  Location(const char* function_name, const char* file_name, int line_number);
 
   // Provide a default constructor for easy of debugging.
-  Location()
-      : function_name_("Unknown"),
-        file_name_("Unknown"),
-        line_number_(-1) { }
+  Location();
 
   // Comparison operator for insertion into a std::map<> hash tables.
   // All we need is *some* (any) hashing distinction.  Strings should already
   // be unique, so we don't bother with strcmp or such.
   // Use line number as the primary key (because it is fast, and usually gets us
   // a difference), and then pointers as secondary keys (just to get some
   // distinctions).
-  bool operator < (const Location& other) const {
-    if (line_number_ != other.line_number_)
-      return line_number_ < other.line_number_;
-    if (file_name_ != other.file_name_)
-      return file_name_ < other.file_name_;
-    return function_name_ < other.function_name_;
-  }
+  bool operator < (const Location& other) const;

[Evan Martin, 2010/07/15 17:37:33]

Comparators being inlined might be important for performance.

[Elliot Glaysher, 2010/07/15 18:08:10]

I've undone this one. I saw strings and I thought string class comparisons (in
which case I might have been right). A relatively small number of pure
arithmetic operations shouldn't slow things down and this has a chance of
actually being inlined.

 
   const char* function_name() const { return function_name_; }
   const char* file_name()     const { return file_name_; }
   int line_number()           const { return line_number_; }
 
   void Write(bool display_filename, bool display_function_name,
              std::string* output) const;
 
   // Write function_name_ in HTML with '<' and '>' properly encoded.
   void WriteFunctionName(std::string* output) const;
@@ skipping 49 matching lines @@
   base::TimeTicks tracked_birth_time_;
 
 #endif  // defined(TRACK_ALL_TASK_OBJECTS)
 
   DISALLOW_COPY_AND_ASSIGN(Tracked);
 };
 
 }  // namespace tracked_objects
 
 #endif  // BASE_TRACKED_H_