Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 3011012: Add URL filter to trigger punycode for Japanese homographic sequences.... (Closed)

Created:
10 years, 5 months ago by jschuh
Modified:
9 years, 6 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add URL filter to trigger punycode for Japanese homographic sequences. BUG=37201 TEST=net_unittests.exe --gtest_filter=NetUtilTest.IDNToUnicode* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M net/base/net_util.cc View 3 chunks +22 lines, -1 line 0 comments Download
M net/base/net_util_unittest.cc View 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jschuh
This might be an ugly solution, but a regex seemed appropriate. Let me know if ...
10 years, 5 months ago (2010-07-19 23:18:58 UTC) #1
jungshik at Google
10 years, 5 months ago (2010-07-27 20:33:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698