Fix nacl_sandbox_tests dependency:...

Fix nacl_sandbox_tests dependency:
allocator target should be added as dependency only when
win_use_allocator_shim is 1.

Also fix a typo in allocator_shim.cc

R=jvoung@google.com, mbelshe@chromium.org
TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52947

[Mike Belshe, 2010-07-19 17:57:06]

LGTM, but one question.

Why does the nacl_sandbox_tests use different compiler options than our other
code?

[jvoung - send to chromium..., 2010-07-19 18:05:03]

http://codereview.chromium.org/3011011/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/3011011/diff/1/3#newcode509
chrome/chrome_tests.gypi:509: ['OS=="win"', {
woh, when did this show up twice -- the 'OS=="win"', ... ?

http://codereview.chromium.org/3011011/diff/1/3#newcode516
chrome/chrome_tests.gypi:516: '../views/views.gyp:views',
should the views also be conditional? It is in nacl_ui_tests (which is what I
tried to copy...)

[Victor Wang, 2010-07-19 18:11:04]

On 2010/07/19 17:57:06, Mike Belshe wrote:
> LGTM, but one question.
> 
> Why does the nacl_sandbox_tests use different compiler options than our other
> code?
All others add allocator dependency if win_use_allocator_shim is 1. I just make
nacl_sandbox_tests using same compiler options as others.

[Victor Wang, 2010-07-19 18:15:45]

http://codereview.chromium.org/3011011/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/3011011/diff/1/3#newcode509
chrome/chrome_tests.gypi:509: ['OS=="win"', {
On 2010/07/19 18:05:03, jvoung wrote:
> woh, when did this show up twice -- the 'OS=="win"', ... ?
I am not sure I got it, I only see one OS==win...

http://codereview.chromium.org/3011011/diff/1/3#newcode516
chrome/chrome_tests.gypi:516: '../views/views.gyp:views',
On 2010/07/19 18:05:03, jvoung wrote:
> should the views also be conditional? It is in nacl_ui_tests (which is what I
> tried to copy...)
I don't think so.

[jvoung - send to chromium..., 2010-07-19 18:23:23]

LGTM

http://codereview.chromium.org/3011011/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/3011011/diff/1/3#newcode509
chrome/chrome_tests.gypi:509: ['OS=="win"', {
On 2010/07/19 18:15:45, Victor Wang wrote:
> On 2010/07/19 18:05:03, jvoung wrote:
> > woh, when did this show up twice -- the 'OS=="win"', ... ?
> I am not sure I got it, I only see one OS==win... 

Ok, n/m I only see one now too. Might have been a glitch when I clicked the
"Expand ..." controls... or a glitch in my vision.