src/profile-generator.cc - Issue 3011009: Add a check that weak object handle is not in NEAR_DEATH state after weak callback invocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profile-generator.cc

Issue 3011009: Add a check that weak object handle is not in NEAR_DEATH state after weak callback invocation. (Closed)

Patch Set: Addressing Mads' comments Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profile-generator.cc

diff --git a/src/profile-generator.cc b/src/profile-generator.cc

index 5315bfbde4fac5bf307d7e614db513afbb8cec9e..7054b125950863776f41a5555d8aeaf807bb5a83 100644

--- a/src/profile-generator.cc

+++ b/src/profile-generator.cc

@@ -74,6 +74,7 @@ void TokenEnumerator::TokenRemovedCallback(v8::Persistent<v8::Value> handle,

void* parameter) {

reinterpret_cast<TokenEnumerator*>(parameter)->TokenRemoved(

Utils::OpenHandle(*handle).location());

+ handle.Dispose();

}

« no previous file with comments | « src/global-handles.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »