Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 3011007: Nukes the nano tab style on gtk and brings back the toolbar for apps (Closed)

Created:
10 years, 5 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Nukes the nano tab style on gtk and brings back the toolbar for apps on gtk. This is a revert of most of r52070and 51478. I've kept parts of these changes we want in though: comments, nuking nano tab gap on views, having app tabs use a bigger icon. BUG=49013 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52830

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -147 lines) Patch
M chrome/browser/gtk/bookmark_bar_gtk.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 4 chunks +6 lines, -19 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_gtk.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -3 lines 1 comment Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 6 chunks +29 lines, -78 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
Elliot could you review this? It's mostly a revert of code you reviewed from Rafael. ...
10 years, 5 months ago (2010-07-16 21:00:52 UTC) #1
Elliot Glaysher
OK
10 years, 5 months ago (2010-07-16 21:09:04 UTC) #2
rafaelw
10 years, 5 months ago (2010-07-16 21:10:19 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698