Issue 3010056: Add --show-output option to parallel_emerge which prints output from jobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3010056: Add --show-output option to parallel_emerge which prints output from jobs. (Closed)

Created:
10 years, 4 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, rtc

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Add --show-output option to parallel_emerge which prints output from jobs. Also update parallel_emerge to print output in general if you hit CTRL-C or if a job is running for more than an hour. Also cleanup exit handling so that emerge exits a bit more cleanly, and so that we don't hang if emerge throws an Exception. BUG=none TEST=Ran ./parallel_emerge --show-output -uDNve chromeos

Patch Set 1 #

Patch Set 2 : Style nits #

Patch Set 3 : Cleanup Exception handling #

Total comments: 1

Patch Set 4 : Update comment #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -38 lines)			Patch
	M	parallel_emerge	View	1 2 3	15 chunks	+192 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

10 years, 4 months ago (2010-08-06 22:10:02 UTC) #2

lgtm w/ additional comments

http://codereview.chromium.org/3010056/diff/7001/8001
File parallel_emerge (right):

http://codereview.chromium.org/3010056/diff/7001/8001#newcode1132
parallel_emerge:1132: # Try to exit cleanly
Can you ad a bit of comment about how this works with multiple subprocesses.
Does sys exit or ^C propagate between subprocesses?

Expand Messages | Collapse Messages