Issue 3010051: Fix shell quoting in tools/valgrind/waterfall.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3010051: Fix shell quoting in tools/valgrind/waterfall.sh (Closed)

Created:
10 years, 4 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko, Timur Iskhodzhanov

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix shell quoting in tools/valgrind/waterfall.sh BUG=none TEST=cd tools; mv valgrind "valgrind --help " ; "./valgrind --help "/waterfall.sh fetch; "./valgrind --help "/waterfall.sh match

Patch Set 1 #

Patch Set 2 : remove debugging echo #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	tools/valgrind/waterfall.sh	View	1	3 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

10 years, 4 months ago (2010-08-05 07:39:58 UTC) #3

Commited as http://codereview.chromium.org/3080032 since un-quoted "rm -rf" can
be scary

Thank you very much for the fix!

Expand Messages | Collapse Messages