Issue 3010031: [Mac] Elide long Omnibox contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3010031: [Mac] Elide long Omnibox contents. (Closed)

Created:
10 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Elide long Omnibox contents. Doing the most simple eliding, which is to truncate and replace with ellipses on a character basis. I put this in the code rather than the .xib because this seems like it should be a hard-wired Omnibox behavior. BUG=50253 TEST=Put in a very long URL and check that it elides as the window gets too small for it to fit. You can easily craft long URLs by adding # and filling with whatever you desire after that. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53826

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/location_bar/autocomplete_text_field.mm	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2010/07/26 19:50:01, shess wrote:
> 

LGTM!

Expand Messages | Collapse Messages