Issue 3009003: build_image: add temporary hack to fix syslinux building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3009003: build_image: add temporary hack to fix syslinux building. (Closed)

Created:
10 years, 5 months ago by adlr

Modified:
9 years ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

build_image: add temporary hack to fix syslinux building. Will Drewry is working on the proper fix, but this unblocks people who build images that boot w/ syslinux.

Patch Set 2 : address sosa's style comment #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	build_image	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sosa

http://codereview.chromium.org/3009003/diff/1/2 File build_image (right): http://codereview.chromium.org/3009003/diff/1/2#newcode374 build_image:374: ${SCRIPTS_DIR}/mount_gpt_image.sh -u -r "${ROOT_FS_DIR}" \ I think it's cleaner ...

10 years, 5 months ago (2010-07-15 18:33:17 UTC) #2

LGTM w/ TEST= :)

Expand Messages | Collapse Messages

Issue 3009003: build_image: add temporary hack to fix syslinux building. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address sosa's style comment #

Messages