Issue 3008017: Port inline in-object property stores from ia32 to x64.

Issue 3008017: Port inline in-object property stores from ia32 to x64. (Closed)

Created:
10 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port inline in-object property stores from ia32 to x64. Committed: http://code.google.com/p/v8/source/detail?r=5115

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -23 lines)			Patch
M	src/ia32/codegen-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2	4 chunks	+104 lines, -10 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		5 chunks	+53 lines, -8 lines	0 comments	Download
M	src/x64/virtual-frame-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/3008017/diff/10001/11003 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/3008017/diff/10001/11003#newcode8029 src/x64/codegen-x64.cc:8029: __ Move(kScratchRegister, Factory::null_value()); Should you avoid using __ ...

10 years, 5 months ago (2010-07-21 16:06:45 UTC) #2

Mads Ager (chromium)

10 years, 5 months ago (2010-07-22 06:30:59 UTC) #3

http://codereview.chromium.org/3008017/diff/10001/11003
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/3008017/diff/10001/11003#newcode8029
src/x64/codegen-x64.cc:8029: __ Move(kScratchRegister, Factory::null_value());
On 2010/07/21 16:06:45, William Hesse wrote:
> Should you avoid using __ between patch_site and moving the map to
> kScratchRegister?

I probably should. I don't think the code coverage support is working at the
moment but no reason to break it on purpose. :)

Thanks. Done.

http://codereview.chromium.org/3008017/diff/10001/11004
File src/x64/ic-x64.cc (right):

http://codereview.chromium.org/3008017/diff/10001/11004#newcode1756
src/x64/ic-x64.cc:1756: int encoded_offsets =
*reinterpret_cast<int*>(encoded_offsets_address);
On 2010/07/21 16:06:45, William Hesse wrote:
> Should you use int32_t here?  We have never asserted that int is 32 bits, I
> think.

There is a lot of code that uses the knowledge that int is 32-bit on x64
already. This is following the style used in the rest of the patching code.

Expand Messages | Collapse Messages