Issue 3007032: Minor fixes of search engine dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3007032: Minor fixes of search engine dialog (Closed)

Created:
10 years, 4 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews, finnur+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Allow search engine dialog to have only two choices (Vietnam and Iran have only two listed in template_url_prepopulate_data). Fix invalid search URL in in.gr search engine. BUG=51295 TEST= Vietnam and Iran search engine dialogs work fine, searching with in.gr (from Greek default search engine choices) works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55164

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	chrome/browser/search_engines/template_url_prepopulate_data.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/views/first_run_search_engine_view.cc	View	1 2	4 chunks	+18 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages