Issue 3007030: bsdiff: force off_t to be 64 bits, honor size_t length

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3007030: bsdiff: force off_t to be 64 bits, honor size_t length (Closed)

Created:
10 years, 4 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush

Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git

Visibility:
Public.

Description

bsdiff: force off_t to be 64 bits, honor size_t length BUG=chromium-os:5364 TEST=tested doing a delta update on a device

Patch Set 2 : fix size_t max handling #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -30 lines)			Patch
	M	dev-util/bsdiff/bsdiff-4.3-r1.ebuild	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	dev-util/bsdiff/files/4.3_bspatch-support-input-output-positioning.patch	View	1	12 chunks	+19 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

One question... http://codereview.chromium.org/3007030/diff/1/3 File dev-util/bsdiff/files/4.3_bspatch-support-input-output-positioning.patch (right): http://codereview.chromium.org/3007030/diff/1/3#newcode137 dev-util/bsdiff/files/4.3_bspatch-support-input-output-positioning.patch:137: +static const int64_t kMaxSizeT = (((int64_t)1) << ...

10 years, 4 months ago (2010-08-04 04:36:24 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 3007030: bsdiff: force off_t to be 64 bits, honor size_t length (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix size_t max handling #

Messages