Issue 3007002: Wrapper script around run_remote_tests that knows about test cells

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3007002: Wrapper script around run_remote_tests that knows about test cells (Closed)

Created:
10 years, 5 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Wrapper script around run_remote_tests that knows about test cells This is a first pass. I'll review this code myself and do more testing, but I wanted to get folks a look at it to make sure I was going in the right direction. BUG=none TEST=ran using both cell and hostname scenarios

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -0 lines)			Patch
	A	bin/cros_run_wifi_tests.sh	View		1 chunk	+149 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

10 years, 5 months ago (2010-07-15 17:46:13 UTC) #2

LGTM modulo nits

http://codereview.chromium.org/3007002/diff/1/2
File bin/cros_run_wifi_tests.sh (right):

http://codereview.chromium.org/3007002/diff/1/2#newcode29
bin/cros_run_wifi_tests.sh:29: #    ${autotest}/files/client/config/ directory
Is it still necessary to have these config files in the autotest tree?  If we
can pass everything on the cmd line then we can do away with this requirement
which is problematic.

http://codereview.chromium.org/3007002/diff/1/2#newcode115
bin/cros_run_wifi_tests.sh:115: cell_no=0
Maybe default FLAG_cell to "0" and set this from it?

Expand Messages | Collapse Messages