Issue 3006006: build_image,update_bootloaders: directly update the built image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3006006: build_image,update_bootloaders: directly update the built image (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

build_image,update_bootloaders: directly update the built image Instead of playing mount and loop device games, this change adds support for update_bootloaders.sh to directly update the EFI system partition living in the image if a file, offset, and size is supplied. TEST=build_image for x86-generic; booted resulting image BUG=broken build Change-Id: I3d891fd965df6fb4abfc63d660e314c497a4184d

Patch Set 1 #

Patch Set 2 : s/else/elif #

Patch Set 3 : fix to_size test #

Patch Set 4 : convert sectors to size and fix esp_size using partoffset #

Patch Set 5 : syslinux should operate on the dev #

Patch Set 6 : one last upload just to make sure I didnt forget anything #

Total comments: 4

Patch Set 7 : style and comment nits #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -16 lines)			Patch
	M	build_image	View	1 2 3 4 5 6	5 chunks	+20 lines, -12 lines	0 comments	Download
	M	update_bootloaders.sh	View	1 2 3 4 5 6	3 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ comments http://codereview.chromium.org/3006006/diff/11001/12001 File build_image (right): http://codereview.chromium.org/3006006/diff/11001/12001#newcode384 build_image:384: # Temporary hack to fix syslinux ...

10 years, 5 months ago (2010-07-16 19:30:41 UTC) #2

Will Drewry

10 years, 5 months ago (2010-07-16 19:32:48 UTC) #3

nits fixed!

http://codereview.chromium.org/3006006/diff/11001/12001
File build_image (right):

http://codereview.chromium.org/3006006/diff/11001/12001#newcode384
build_image:384: # Temporary hack to fix syslinux building, comment out -e
${ESP_FS_DIR}
On 2010/07/16 19:30:48, adlr wrote:
> remove this comment?

Done.

http://codereview.chromium.org/3006006/diff/11001/12002
File update_bootloaders.sh (right):

http://codereview.chromium.org/3006006/diff/11001/12002#newcode14
update_bootloaders.sh:14: set -x
On 2010/07/16 19:30:48, adlr wrote:
> remove

Done.

Expand Messages | Collapse Messages