Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: depot_tools/gclient.py

Issue 3005027: Reverting 53377, horks webkit waterfall. (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | depot_tools/tests/gclient_smoketest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: depot_tools/gclient.py
===================================================================
--- depot_tools/gclient.py (revision 53418)
+++ depot_tools/gclient.py (working copy)
@@ -296,8 +296,8 @@
if name in [s.name for s in self.dependencies]:
raise
self.dependencies.append(Dependency(self, name, url))
- # Note: do not sort by name, the dependencies must be specified in the
- # logical order.
+ # Sort by name.
+ self.dependencies.sort(key=lambda x: x.name)
logging.info('Loaded: %s' % str(self))
def RunCommandRecursively(self, options, revision_overrides,
« no previous file with comments | « no previous file | depot_tools/tests/gclient_smoketest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698