Issue 3005026: Make Dependency.subtree() a standalone function for later use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3005026: Make Dependency.subtree() a standalone function for later use. (Closed)

Created:
10 years, 5 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn, dglazkov1

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Make Dependency.subtree() a standalone function for later use. No behavior change. TEST=all test still pass TBR=bradnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53392

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	gclient.py	View		2 chunks	+11 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

It's related to searching a From() in grand-child dependencies. Separating the change to make it ...

10 years, 5 months ago (2010-07-22 21:37:31 UTC) #1

bradn

Formatting issue, otherwise LGTM. http://codereview.chromium.org/3005026/diff/1/2 File gclient.py (right): http://codereview.chromium.org/3005026/diff/1/2#newcode430 gclient.py:430: result.append(d) extra indent here.

10 years, 5 months ago (2010-07-22 21:51:49 UTC) #2

dglazkov1

10 years, 5 months ago (2010-07-22 22:46:00 UTC) #3

I think this broke build.webkit.org builders:
http://build.webkit.org/waterfall?show=Chromium%20Win%20Release

Expand Messages | Collapse Messages