Issue 3005022: Print a better error message when someone passes the wrong parameters to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3005022: Print a better error message when someone passes the wrong parameters to (Closed)

Created:
10 years, 5 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews, pam+watch_chromium.org, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Print a better error message when someone passes the wrong parameters to sendRequest. BUG=46094 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53228

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/renderer/resources/renderer_extension_bindings.js	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

LGTM This still doesn't address the using reserved names issue from the bug, right?

10 years, 5 months ago (2010-07-20 19:21:56 UTC) #2

Matt Perry

On 2010/07/20 19:21:56, Erik Kay wrote: > This still doesn't address the using reserved names ...

10 years, 5 months ago (2010-07-20 19:22:54 UTC) #3

Erik does not do reviews

10 years, 5 months ago (2010-07-20 19:26:57 UTC) #4

OK.  I guess just update the bug then.

Actually, re-reading his comment, the circular reference means he's just
inserting the result into itself.  I don't think changing the name was
fixing it for him.

Erik

On Tue, Jul 20, 2010 at 12:22 PM, <mpcomplete@chromium.org> wrote:

> On 2010/07/20 19:21:56, Erik Kay wrote:
>
>> This still doesn't address the using reserved names issue from the bug,
>> right?
>>
>
> There are no reserved names. I couldn't reproduce that commenter's issue. I
> think he was seeing something else.
>
>
> http://codereview.chromium.org/3005022/show
>

Expand Messages | Collapse Messages