Issue 3005013: Update the sync node title for classic autofill to be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3005013: Update the sync node title for classic autofill to be (Closed)

Created:
10 years, 5 months ago by albertb

Modified:
9 years, 3 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Description

Update the sync node title for classic autofill to be "autofill_entry|$name|$value". BUG=40876 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53219

Patch Set 1 #

Patch Set 2 : rebase #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/sync/glue/autofill_change_processor.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/sync/glue/autofill_model_associator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM. You agree this is safe against the Model Associator rewriting all the entries, right?

10 years, 5 months ago (2010-07-20 21:12:06 UTC) #2

albertb

10 years, 5 months ago (2010-07-20 21:19:34 UTC) #3

On 2010/07/20 21:12:06, ncarter wrote:
> LGTM.
> 
> You agree this is safe against the Model Associator rewriting all the entries,
> right?
Yes, this patch will only affect newly created autofill sync nodes. Existing
nodes will keep their current title.

Expand Messages | Collapse Messages