Issue 30001: Add missing bool parameter to changeLocation(). This causes us to not update...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 30001: Add missing bool parameter to changeLocation(). This causes us to not update... (Closed)

Created:
11 years, 10 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add missing bool parameter to changeLocation(). This causes us to not update the back/forward list and current location since it thinks history is locked. BUG=7625 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10147

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	third_party/WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

brettw

I checked other calls of changeLocation and I think they're OK.

11 years, 10 months ago (2009-02-21 02:12:09 UTC) #1

LGTM