chrome/gpu/gpu_backing_store_win.cc - Issue 2997002: Coverity: Fix leaking TransportDIB in GpuBackingStore{GLX,Win}::OnPaintToBackingStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/gpu/gpu_backing_store_win.cc

Issue 2997002: Coverity: Fix leaking TransportDIB in GpuBackingStore{GLX,Win}::OnPaintToBackingStore (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: add TransportDIB::Map comment Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/gpu/gpu_backing_store_win.cc

diff --git a/chrome/gpu/gpu_backing_store_win.cc b/chrome/gpu/gpu_backing_store_win.cc

index a38e8b9e2bbcd08dfff97a4f7f862a8c4a21b0e1..d5af441c89661170420697c4e75384c5af8d4f49 100644

--- a/chrome/gpu/gpu_backing_store_win.cc

+++ b/chrome/gpu/gpu_backing_store_win.cc

@@ -130,8 +130,8 @@ void GpuBackingStoreWin::OnPaintToBackingStore(

HANDLE section = win_util::GetSectionFromProcess(

id.handle, source_process_handle, false /* read write */);

CHECK(section);

- TransportDIB* dib = TransportDIB::Map(section);

- CHECK(dib);

+ scoped_ptr<TransportDIB> dib(TransportDIB::Map(section));

+ CHECK(dib.get());

if (!backing_store_dib_) {

backing_store_dib_ = CreateDIB(hdc_, size_.width(),

« no previous file with comments | « chrome/gpu/gpu_backing_store_glx.cc ('k') | no next file » | no next file with comments »