Issue 2993006: Implement ES5 Object.seal and Object.isSealed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2993006: Implement ES5 Object.seal and Object.isSealed.... (Closed)

Created:
10 years, 5 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implement ES5 Object.seal and Object.isSealed. This change adds the ES5 Object.seal 15.2.3.8 and Object.isSealed 15.2.3.11 methods. Committed: http://code.google.com/p/v8/source/detail?r=5072

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -12 lines)			Patch
M	src/v8natives.js	View		3 chunks	+39 lines, -1 line	0 comments	Download
M	test/es5conform/es5conform.status	View		1 chunk	+0 lines, -11 lines	0 comments	Download
A	test/mjsunit/object-seal.js	View	1	1 chunk	+195 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

This will probably break webkit again. I could potentially wait until sunday to commit this ...

10 years, 5 months ago (2010-07-14 13:41:09 UTC) #1

Mads Ager (chromium)

LGTM http://codereview.chromium.org/2993006/diff/1/3 File test/mjsunit/object-seal.js (right): http://codereview.chromium.org/2993006/diff/1/3#newcode174 test/mjsunit/object-seal.js:174: // Test that isSealed returns the correct value ...

10 years, 5 months ago (2010-07-14 13:49:40 UTC) #2

Rico

http://codereview.chromium.org/2993006/diff/1/3 File test/mjsunit/object-seal.js (right): http://codereview.chromium.org/2993006/diff/1/3#newcode174 test/mjsunit/object-seal.js:174: // Test that isSealed returns the correct value even ...

10 years, 5 months ago (2010-07-14 14:00:23 UTC) #3

Added new version of es5conform.status

Expand Messages | Collapse Messages

Issue 2993006: Implement ES5 Object.seal and Object.isSealed.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages