Issue 2990001: Teach parallel_emerge to uninstall packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2990001: Teach parallel_emerge to uninstall packages. (Closed)

Created:
10 years, 5 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Teach parallel_emerge to uninstall packages. Currently, parallel_emerge doesn't know how to handle uninstall actions, so it actually installs packages when it should be uninstalling them. This patch fixes that. TEST=sudo ./parallel_emerge -uDNv hard-host-depends, and make sure it uninstalls nih-dbus-tool, which is blocked by hard-host-depends BUG=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unnecessary --oneshot #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	parallel_emerge	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

10 years, 5 months ago (2010-07-13 07:29:41 UTC) #2

lgtm w/ change

http://codereview.chromium.org/2990001/diff/1/2
File parallel_emerge (right):

http://codereview.chromium.org/2990001/diff/1/2#newcode598
parallel_emerge:598: cmdline = EmergeCommand() + " --nodeps --oneshot --unmerge
=" + target
no need for oneshot

Expand Messages | Collapse Messages